Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: bazel upgrade shard_count #41417

Merged
merged 4 commits into from
Feb 15, 2023
Merged

*: bazel upgrade shard_count #41417

merged 4 commits into from
Feb 15, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Feb 15, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei
*: bazel upgrade shard_count
a855cc2 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 15, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 15, 2023
@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Feb 15, 2023
Defined2014
Defined2014 approved these changes Feb 15, 2023
View reviewed changes
util/ranger/BUILD.bazel Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 15, 2023
@hawkingrei hawkingrei requested a review from YangKeao February 15, 2023 03:23
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 15, 2023
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dc649b9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 15, 2023
@ti-chi-bot ti-chi-bot merged commit 0e3f5a8 into pingcap:master Feb 15, 2023
@hawkingrei hawkingrei deleted the update_bazel_config branch February 15, 2023 04:32
blacktear23 pushed a commit to blacktear23/tidb that referenced this pull request Feb 15, 2023
@hawkingrei @blacktear23
*: bazel upgrade shard_count (pingcap#41417)
d68629f
ghazalfamilyusa pushed a commit to ghazalfamilyusa/tidb that referenced this pull request Feb 15, 2023
@hawkingrei @ghazalfamilyusa
*: bazel upgrade shard_count (pingcap#41417)
652641d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

@lance6716 lance6716 Awaiting requested review from lance6716

@YangKeao YangKeao Awaiting requested review from YangKeao

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hawkingrei @ti-chi-bot @Defined2014 @tangenta